Add flaky pytest infrastructure and weekend runners #1799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dime10
requested changes
Jun 10, 2025
paul0403
commented
Jun 10, 2025
|
Since this action installs from testpypi, this PR's CI will fail tests for tests depending on new features still not on testpypi yet. For example, Tuesday midnight's test pypi will fail tests added on Wednesday. This is fine. I only enable the script on PRs to check the script itself. |
paul0403
commented
Jun 11, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1799 +/- ##
=======================================
Coverage 96.61% 96.61%
=======================================
Files 82 82
Lines 9265 9265
Branches 875 875
=======================================
Hits 8951 8951
Misses 255 255
Partials 59 59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
paul0403
commented
Jun 11, 2025
paul0403
commented
Jun 13, 2025
dime10
approved these changes
Jun 13, 2025
Co-authored-by: David Ittah <dime10@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
We wish to reduce flaky tests in CI.
There is a python package
flaky(which we already have in ourrequirements.txt) that reruns failed tests to hunt for flakiness.Let's actually use it.
Description of the Change:
flakyinfrastructure. A pytest run that hunts for flaky tests can be launched bymake pytest ENABLE_FLAKY=ONBenefits:
If any new tests are flaky, this weekend runner will catch them!
[sc-87028]